-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat monorepo #614
Merged
Merged
Feat monorepo #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…ix the docker build
… elements container. should fix e2e tests
I implemented 2 workspaces. One top level, including examples/ and frontend/ and on in frontend/. The second one is only for use in the Docker build process, because the Dockerfile can only access ./ but not ../ so we need a package.json in ./ As @bjoern-m suggested, we could move the examples into the frontend folder to reduce the complexity here. |
lfleischmann
reviewed
Mar 3, 2023
Co-authored-by: lfleischmann <67686424+lfleischmann@users.noreply.github.com>
Co-authored-by: lfleischmann <67686424+lfleischmann@users.noreply.github.com>
Co-authored-by: lfleischmann <67686424+lfleischmann@users.noreply.github.com>
…ents-issues Feat monorepo solve hanko elements issues
bjoern-m
approved these changes
Mar 6, 2023
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You may have to delete the different node_modules folders/ package-lock.json to get this working.
If you don't run on M1 you have to install turbo globally:
Implementation
Tests
Todos
Additional context