Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment status validation when number of pods more than 256 #114

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@notmaxx
Copy link
Contributor

notmaxx commented Jan 9, 2020

is not is the way to compare objects but not numbers, now it works only because of this https://stackoverflow.com/questions/306313/is-operator-behaves-unexpectedly-with-integers. Once number of pods become more than 256 it stops working

@Cryptophobia Cryptophobia requested review from Cryptophobia and kingdonb Jan 9, 2020
Copy link
Member

Cryptophobia left a comment

lgtm, thanks @notmaxx !

@Cryptophobia Cryptophobia merged commit ce67616 into teamhephy:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.