Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployment status validation when number of pods more than 256 #114

Merged
merged 1 commit into from Jan 9, 2020
Merged

Fix deployment status validation when number of pods more than 256 #114

merged 1 commit into from Jan 9, 2020

Conversation

notmaxx
Copy link
Contributor

@notmaxx notmaxx commented Jan 9, 2020 •
edited

is not is the way to compare objects but not numbers, now it works only because of this https://stackoverflow.com/questions/306313/is-operator-behaves-unexpectedly-with-integers. Once number of pods become more than 256 it stops working

Cryptophobia
Cryptophobia approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @notmaxx !

@Cryptophobia Cryptophobia merged commit ce67616 into teamhephy:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryptophobia Cryptophobia Cryptophobia approved these changes

@kingdonb kingdonb Awaiting requested review from kingdonb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@notmaxx @Cryptophobia