Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop scikit-learn 0.17.x support #50

Closed
kmike opened this issue Nov 2, 2016 · 1 comment
Closed

drop scikit-learn 0.17.x support #50

kmike opened this issue Nov 2, 2016 · 1 comment

Comments

@kmike
Copy link
Contributor

kmike commented Nov 2, 2016

I tried to add tests for scikit-learn 0.17, but it turns out compatibility shims in eli5.lime don't work - e.g. KFold has different API. What do you think about dropping scikit-learn 0.17 support, and supporting only 0.18.x? //cc @lopuhin
@lopuhin
Copy link
Contributor

lopuhin commented Nov 3, 2016

I think that's fine to drop it @kmike . I checked eli5.sklearn tests: they pass on 0.17.1, but I don't think supporting it is worth the complexity.

@kmike kmike closed this as completed in 6ff566f Nov 3, 2016
kmike added a commit that referenced this issue Nov 3, 2016
@kmike
Merge pull request #54 from TeamHG-Memex/drop-sklearn-0.17
8da5169 
remove workarounds for scikit-learn < 0.18. Fixed GH-50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmike @lopuhin