Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles are broken for NER docs #98

Open
kmike opened this issue Nov 21, 2016 · 3 comments
Open

styles are broken for NER docs #98

kmike opened this issue Nov 21, 2016 · 3 comments

Comments

@kmike
Copy link
Contributor

kmike commented Nov 21, 2016

Weight tables don't fit the column at http://eli5.readthedocs.io/en/latest/tutorials/sklearn_crfsuite.html, and there is no scrolling - tables are just truncated.

I was able to fix it locally using custom CSS, but had to revert the fix (153ab4a) because on readthedocs.io original stylesheet was not loaded for some reason.

@lopuhin
Copy link
Contributor

lopuhin commented Nov 22, 2016

hm, RTD applies some hack to make tables look nice (places them in a div with overflow: auto), but it applies it only to the second table. Maaybe if we make all our explanations have one root div (maybe even without styles?), it will work better.

@lopuhin
Copy link
Contributor

lopuhin commented Nov 22, 2016

The same problem in the second table here: http://eli5.readthedocs.io/en/latest/tutorials/sklearn-text.html#debugging-hashingvectorizer - here it breaks with just one table

@kmike
Copy link
Contributor Author

kmike commented Nov 22, 2016

For me this css file fixed the issue locally (well, not perfectly); the problem is that I was not able to load it in readthedocs. Locally it worked fine, but on readthedocs.io it was the only theme css file loaded, so styles were broken.

@kmike kmike added this to the 0.1 milestone Nov 23, 2016
@kmike kmike self-assigned this Nov 23, 2016
@kmike kmike removed this from the 0.1 milestone Nov 23, 2016
@kmike kmike removed their assignment Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants