Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer reviewee mix up in reports page #34

Closed
damithc opened this issue May 2, 2014 · 7 comments
Closed

Reviewer reviewee mix up in reports page #34

damithc opened this issue May 2, 2014 · 7 comments

Comments

@damithc
Copy link
Contributor

damithc commented May 2, 2014

From dam...@gmail.com on February 12, 2011 22:23:02

In the reports page (for coordinator), the button says 'view by reviewer' when the view is already 'by reviewer' Shouldn't it be the other way?

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=34

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From jdwxj...@gmail.com on February 12, 2011 20:25:06

I didn't know which way would make more sense. But since you pointed it out to be the other way I will change it to the other way.

Status: Accepted
Labels: Type-Enhancement Priority-Medium

1 similar comment
@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From jdwxj...@gmail.com on February 12, 2011 20:25:06

I didn't know which way would make more sense. But since you pointed it out to be the other way I will change it to the other way.

Status: Accepted
Labels: Type-Enhancement Priority-Medium

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From dam...@gmail.com on February 12, 2011 20:38:45

Buttons are actions. Therefore, 'view by reviewer' means 'press this button to view by reviewer' which is the button text that should be displayed when the view is actually 'by reviewee'.
BTW, consider adding a title above the report. In that case, the title would be 'by reviewee' while the button will be 'view by reviewer'

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From jdwxj...@gmail.com on February 13, 2011 05:06:51

Status: Started

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From jdwxj...@gmail.com on February 13, 2011 05:46:50

Fixed. The heading now reflects which mode the coordinator is viewing by.

Status: Fixed

@damithc
Copy link
Contributor Author

damithc commented May 2, 2014

From smkhaa...@gmail.com on September 03, 2011 11:37:28

Invalid now after the new design of the Reports page.

Status: Invalid
Owner: jdwxj...@gmail.com

@damithc
Copy link
Contributor Author

damithc commented Jul 25, 2014

[Change Log]
status: ~> closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant