correct incorrect tests

teamneusta · Aug 15, 2023 · 493e432 · 493e432
1 parent 6f8fafe
commit 493e432
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Populator/ArrayConvertingPopulator.php b/src/Populator/ArrayConvertingPopulator.php
@@ -32,11 +32,12 @@ final class ArrayConvertingPopulator implements Populator
     public function __construct(
         Converter                 $converter,
         string                    $sourceArrayPropertyName,
-        string                    $sourceArrayItemPropertyName,
         string                    $targetPropertyName,
+        ?string                   $sourceArrayItemPropertyName = null,
         PropertyAccessorInterface $itemAccessor = null,
         PropertyAccessorInterface $accessor = null,
-    ) {
+    )
+    {
         $this->populator = new ArrayPropertyMappingPopulator(
             $targetPropertyName,
             $sourceArrayPropertyName,

diff --git a/tests/app/config/services.yaml b/tests/app/config/services.yaml
@@ -62,7 +62,6 @@ services:
         arguments:
             $converter: '@test.contactnumber.converter'
             $sourceArrayPropertyName: 'phones'
-            $sourceArrayItemPropertyName: ''
             $targetPropertyName: 'contactNumbers'
 
     Neusta\ConverterBundle\Tests\Fixtures\Model\PersonFactory: ~