Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping null values #69

Merged
merged 10 commits into from
Apr 2, 2024
Merged

Allow skipping null values #69

merged 10 commits into from
Apr 2, 2024

Conversation

mike4git
Copy link
Collaborator

@mike4git mike4git commented Mar 18, 2024 •
edited by jdreesen
Loading

  • add skip_null to Configuration
  • add $skipNull parameter to PropertyMappingPopulator
  • add test for dot operator
  • add debug functionality to php docker container for testing

Fixes #68

@mike4git mike4git linked an issue Mar 18, 2024 that may be closed by this pull request
[PropertyMappingPopulator] Make null safety possible #68
Closed
jdreesen
jdreesen reviewed Mar 18, 2024
View reviewed changes
src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/DependencyInjection/NeustaConverterExtension.php Outdated Show resolved Hide resolved
src/DependencyInjection/NeustaConverterExtension.php Outdated Show resolved Hide resolved
tests/Fixtures/Model/User.php Outdated Show resolved Hide resolved
tests/Populator/PropertyMappingPopulatorTest.php Outdated Show resolved Hide resolved
mike4git and others added 9 commits April 2, 2024 12:30
@mike4git
#68 add nullsafe to Configuration and nullSafety to PropertyMappingPo…
a56a39d 
…pulator

add test for dot operator
add debug functionality to php docker container for testing
@mike4git @jdreesen
Update src/DependencyInjection/Configuration.php
d0b57f9 
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
@mike4git @jdreesen
Update src/DependencyInjection/NeustaConverterExtension.php
805f452 
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
@mike4git @jdreesen
Update src/DependencyInjection/Configuration.php
2c7e776 
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
@mike4git
#68 rename property to skip_null
b6b73af 
add test for Extension class
@mike4git
#68 getter adapted to setter and property
f011b8b
@mike4git
#68 exclude test for older Symfony versions
27887e3
@mike4git
#68 rename configuration property with snake case and attribute with …
b3ac36d 
…camel case
@mike4git
fix tests and rebase upon main
67449d5
@mike4git mike4git force-pushed the 68-propertymappingpopulator-make-null-safety-possible branch from 4ea4263 to 67449d5 Compare April 2, 2024 10:51
@mike4git mike4git requested a review from jdreesen April 2, 2024 10:52
@jdreesen jdreesen changed the title #68 NullSafety #68 Allow skipping null values Apr 2, 2024
@jdreesen jdreesen changed the title #68 Allow skipping null values Allow skipping null values Apr 2, 2024
@jdreesen jdreesen merged commit fc9398a into main Apr 2, 2024
5 checks passed
@jdreesen jdreesen deleted the 68-propertymappingpopulator-make-null-safety-possible branch April 2, 2024 16:42
@jdreesen jdreesen restored the 68-propertymappingpopulator-make-null-safety-possible branch April 2, 2024 16:58
@jdreesen jdreesen deleted the 68-propertymappingpopulator-make-null-safety-possible branch April 2, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PropertyMappingPopulator] Make null safety possible
2 participants
@mike4git @jdreesen