Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #70

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Refactor tests #70

merged 5 commits into from
Mar 22, 2024

Conversation

jdreesen
Copy link
Member

This refactors the integration tests utilizing the Symfony Bundle Test library and the extension (DI) tests utilizing the Symfony Dependency Injection Test library which serve as a good basis, make them easier to read and offer some possibilities for Symfony Bundle related tests in the future.

@jdreesen
Copy link
Member Author

Needs #71.

@mike4git
Copy link
Collaborator

Nice approach to keep testing configs easy to read and to handle.

What would you think about seperating model classes into two subfolders:

  • Source
  • Target

just to calrify what belongs to each other?!

Copy link
Collaborator

@mike4git mike4git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for this improvement of test readability

@jdreesen jdreesen merged commit 89bbb64 into main Mar 22, 2024
5 checks passed
@jdreesen jdreesen deleted the task-refactor-tests branch March 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants