Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ArrayPropertyMappingPopulator #74

Merged
merged 2 commits into from
May 7, 2024
Merged

Refactor ArrayPropertyMappingPopulator #74

merged 2 commits into from
May 7, 2024

Conversation

jdreesen
Copy link
Member

@jdreesen jdreesen commented Apr 4, 2024

I have refactored the ArrayPropertyMappingPopulator to reuse the PropertyMappingPopulator as we already do in ConvertingPopulator and ArrayConvertingPopulator.

mike4git
mike4git approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@mike4git mike4git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich bräuchte da etwas Aufklärung, aber da die Tests grün sind und Du ja den PropertyMappingPopulator nutzt, geht es aus meiner Sicht in Ordnung.

src/Populator/ArrayPropertyMappingPopulator.php Show resolved Hide resolved
src/Populator/ArrayPropertyMappingPopulator.php Show resolved Hide resolved
@jdreesen jdreesen merged commit ea3f6d5 into main May 7, 2024
5 checks passed
@jdreesen jdreesen deleted the refactor-populators branch May 7, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike4git mike4git mike4git approved these changes

@lukadschaak lukadschaak Awaiting requested review from lukadschaak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdreesen @mike4git