abort transaction if something fails

teamniteo · Dec 28, 2012 · 76346c6 · 76346c6
1 parent b734a18
commit 76346c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/docs/CHANGELOG.rst b/docs/CHANGELOG.rst
@@ -4,6 +4,9 @@ Changelog
 1.1 (Unreleased)
 ----------------
 
+- Abort transaction if something fails.
+  [zupo]
+
 - Use 'ipn_' as a prefix for product group IDs.
   [zupo]
 

diff --git a/src/niteoweb/ipn/jvzoo/jvzoo.py b/src/niteoweb/ipn/jvzoo/jvzoo.py
@@ -9,6 +9,7 @@
 from Products.CMFCore.interfaces import ISiteRoot
 from zope.component import getAdapter
 
+import transaction
 import hashlib
 import logging
 
@@ -72,16 +73,19 @@ def render(self):
         except KeyError as ex:
             msg = "POST parameter missing: %s" % ex
             logger.warning(msg)
+            transaction.abort()
             return msg
 
         except AssertionError:
             msg = "Checksum verification failed."
             logger.warning(msg)
+            transaction.abort()
             return msg
 
         except Exception as ex:
             msg = "POST handling failed: %s" % ex
             logger.warning(msg)
+            transaction.abort()
             return msg
 
         return 'Done.'