Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile browser address bar and bottom navigation viewport #55

Closed
toreylittlefield opened this issue Sep 21, 2023 · 0 comments · Fixed by #57 or #60
Closed

Mobile browser address bar and bottom navigation viewport #55

toreylittlefield opened this issue Sep 21, 2023 · 0 comments · Fixed by #57 or #60
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@toreylittlefield
Copy link
Collaborator

Reproduce issue

  1. Visit https://teampetpoison.github.io/pet-poison-alert/ on a mobile device and browser
  2. Observe that the browser's navigation bar is causing the app's bottom navigation to not fit in the viewport

This is a common issue. See something like https://css-tricks.com/the-trick-to-viewport-units-on-mobile/ to apply a fix by calculating the correct height for the viewport instead of using height:100vh units

@toreylittlefield toreylittlefield added bug Something isn't working good first issue Good for newcomers labels Sep 21, 2023
@toreylittlefield toreylittlefield self-assigned this Sep 22, 2023
@toreylittlefield toreylittlefield linked a pull request Sep 22, 2023 that will close this issue
3 tasks
@toreylittlefield toreylittlefield linked a pull request Sep 24, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant