Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Not Being Saved #131

Closed
moriel5 opened this issue Apr 16, 2021 · 11 comments
Closed

Settings Not Being Saved #131

moriel5 opened this issue Apr 16, 2021 · 11 comments

Comments

@moriel5
Copy link

moriel5 commented Apr 16, 2021

I usually prefer setting the sponsor segments of the videos I watch, since I do like them (I watch mainly LinusTechTips (and their other channels), Gamers Nexus, and Level1Techs), and occasionally make use of them, so I tried disabling SponsorBlock and the other settings, however my changes do not get saved, and upon leaving the page, they get reverted.

@FireMasterK
Copy link
Member

There are two possibilities for this:

  • You have cookies/localstorage disabled
  • Something is preventing the settings from being saved in a particular browser

Can you take a screenshot of the localstorage tab in devtools? Please also specify the browser you are using.

@moriel5
Copy link
Author

moriel5 commented Apr 17, 2021

Will do so once I can turn on my desktop again (real life chores first).

And 3rd party cookies are blocked, but not local storage.

As for the browser, I have seen this behaviour on both Firefox (Nightly) and Edge (Dev), both on Solus (Linux).

@moriel5
Copy link
Author

moriel5 commented Apr 18, 2021

Sorry it took so long.
Oddly enough, on Edge, the values remained the same no matter what, while on Firefox they changed in accordance to what I had disabled (though still not saved).

Screenshot from 2021-04-18 02:43:55
Screenshot from 2021-04-18 02:44:43

@FireMasterK
Copy link
Member

FireMasterK commented Apr 18, 2021

So, if I'm correct this is only reproducible when you disable everything. right?
(Enable Sponsorblock is still being saved correctly)

@moriel5
Copy link
Author

moriel5 commented Apr 18, 2021

It happens regardless of what I do, not just disabling everything.

@FireMasterK
Copy link
Member

I'm sorry, but I'm still unable to reproduce this issue, could you try without any extensions?

@moriel5
Copy link
Author

moriel5 commented Apr 18, 2021

No problem, as soon as I'll be on my desktop.

@moriel5
Copy link
Author

moriel5 commented Apr 18, 2021

While testing performance in issue #132, I checked (extensions enabled) and it appears that it only happens when disabling all options.

The Chromebook is my sister's laptop, so I'll be running a proper check once I'm on my desktop (where Edge is also installed).

Update: Disabling all extensions does not change any anything, however interestingly, despite not showing anything changing within Local Storage, Edge displays the same behaviour, as in, the settings do get saved, however attempting to disable all sponsorblock options resets all options to their defaults.

@FireMasterK
Copy link
Member

Edge displays the same behaviour, as in, the settings do get saved, however attempting to disable all sponsorblock options resets all options to their defaults.

I was able to replicate this issue, thanks for reporting!

I'll fix this later tomorrow

@FireMasterK
Copy link
Member

This issue should be fixed now, do let me know if it isn't!

@moriel5
Copy link
Author

moriel5 commented Apr 21, 2021

Thanks, I'll test it out when on my desktop.
Update: All's good now.

IvRRimum pushed a commit to IvRRimum/Piped that referenced this issue Oct 24, 2021
blade10101 pushed a commit to blade10101/Piped that referenced this issue Apr 11, 2024
Currently translated at 100.0% (143 of 143 strings)

Translate-URL: https://hosted.weblate.org/projects/piped-material/i18n/ar/
Translation: Piped Material/i18n

Co-authored-by: Mohammed Al Otaibi <mopes.03.belle@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants