F to fullscreen doesn't work

[B0pol]

According to #139 it was already implemented so it's a regression

[FireMasterK]

I cannot replicate this whatsoever, both on Brave and Firefox on Windows and Linux (Gnome 40).

[B0pol]

I can on Firefox 88, ungoogled chromium 88, gnome web 40, on linux (gnome 40)

[B0pol]

I found the problem!

https://github.com/TeamPiped/Piped/blob/master/src/components/Player.vue#L120

I added a console.log(e.code) to see what key it detects

It logs key as if I have a QWERTY keyboard layout but I don't.
F key on my keyboard layout isn't at the same as place as QWERTY, therefore it doesn't work. It says I'm pressing slash /.
If I press the key where F is located on QWERTY, it works.

[B0pol]

You should use e.key instead. See MDN doc for KeyboardEvent.code.

[FireMasterK]

Very interesting! I'll will change this in a few hours.

[FireMasterK]

Could you see if https://650b3348.piped.pages.dev/ fixes the issue?
(#176)

[B0pol]

It does

[ghost]

@FireMasterK, Seems like this issue is now Back. Using Windows 11 with Firefox 93 and also not available on Microsoft Edge Version 94.0.992.38 too.

[FireMasterK]

Fixed at e8f8930.