Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

PhantomJS 1.9 #415

Closed
mschuerig opened this issue Nov 20, 2013 · 4 comments
Closed

PhantomJS 1.9 #415

mschuerig opened this issue Nov 20, 2013 · 4 comments

Comments

@mschuerig
Copy link

The version requirement of ['~> 1.8','>= 1.8.1'] precludes the use of PhantomJS 1.9. Is there any particular reason? I've tried it in a new project on a few features and it seems to work.

@route
Copy link
Contributor

route commented Nov 20, 2013

No reason, must be in the range... I thought ~> 1.8 does this thing...

@yaauie
Copy link
Contributor

yaauie commented Nov 20, 2013

The requirement doesn't preclude 1.9 at all; in fact I only have PhantomJS 1.9 installed and it works just fine.

  • ~> 1.8 will accept any 1.x version greater than 1.8, but will reject 2.0
  • >= 1.8.1 requires the version to be greater than or equal to 1.8.1
phantomjs_path = Cliver.detect!('phantomjs', '~> 1.8', '>= 1.8.1')
# => "/usr/local/bin/phantomjs"
`#{phantomjs_path} --version`.chomp
# => "1.9.0"

@yaauie yaauie closed this as completed Nov 20, 2013
@mschuerig
Copy link
Author

Here's what I get:

irb(main):009:0> phantomjs_path = Cliver.detect('phantomjs', '~> 1.8', '>= 1.8.1')
=> nil
irb(main):010:0> phantomjs_path = Cliver.detect('phantomjs', '~> 1.8')
=> nil
irb(main):011:0> phantomjs_path = Cliver.detect('phantomjs', '>= 1.8.1')
=> "/usr/bin/phantomjs"
irb(main):012:0> `#{phantomjs_path} --version`.chomp
=> "1.9.0"

Also of interest:

irb(main):013:0> Cliver::VERSION
=> "0.2.2"
irb(main):016:0> RUBY_DESCRIPTION
=> "ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-linux]"

The system is a current Debian unstable/sid with phantomjs package 1.9.0-1.

@yaauie
Copy link
Contributor

yaauie commented Nov 20, 2013

Odd. I think this must be a bug with Cliver and I can't reproduce it. I've opened yaauie/cliver#10 & would appreciate if you could follow up over there. Apologies for summarily closing this bug when I couldn't repro locally. =/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants