Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC - Rolling Time Periods + Decay Two Period #4

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

POC - Rolling Time Periods + Decay Two Period #4

wants to merge 27 commits into from
+2,069 −49

Conversation

bonedaddy
Copy link
Collaborator

@bonedaddy bonedaddy commented Aug 18, 2023 •
edited

notes:

  • code was modified to add decay two period ability to rate limits, and add unit tests for decay two period logic however actual rate limits haven't been migrated to use decay two period
  • reason behind this is that actual integration requires significant refactoring to the rate limit functions / workflow

@bonedaddy
basic migration testing
37247d0
@bonedaddy
alter contract version numbers depending on test environment...
4d1a8cb 
include some additional test helpers, enable semver checking for migrations
@bonedaddy
enable cargo workspace settings
406ba4c
@bonedaddy
cleanup contract test functions
cdd96af
@bonedaddy
restructure migration helpers
6af13c4
@bonedaddy
add rate limit rollover helper functions
42ed219
@bonedaddy
wip period rollover functionality
105fdde
@bonedaddy
update precompiled wasm code
0ef16de
@bonedaddy
update rate limiter
f0733f2
@bonedaddy
fix rollover sudo usage
8669c56
@bonedaddy
contract cleanup
86822ac
@bonedaddy
wip rollover testing
e315c5d
@bonedaddy
fix rate limit query test
6384afa
@bonedaddy
reset channel value on rollover
a9ad59f
@bonedaddy
wip middleware testing
4c2a95f
@bonedaddy
update precompiled wasm bytecode
eff6bde
@bonedaddy
update rollover tests
73696aa
@bonedaddy
wip decay two period average
322e291
@bonedaddy
wip basic decay two period contract tests
e17fae3
@bonedaddy
add send + query to decay two period test
abc0726
@bonedaddy
format contract tests
6ec4053
@bonedaddy
fix invalid rule copy
196e5da
@bonedaddy
test updates
0bcbdaa
@bonedaddy
wip rate limit testing
0844935
@bonedaddy
add monthly decay tests
c3d4e9f
@bonedaddy
cherrypick
a48c4d6
@bonedaddy
fix test issues from previous commits
c94d5b3
@bonedaddy bonedaddy mentioned this pull request Aug 18, 2023
Closed
nicolaslara
nicolaslara reviewed Sep 15, 2023
View reviewed changes
x/ibc-rate-limit/contracts/rate-limiter/src/state.rs
@@ -86,25 +86,30 @@ impl Flow {
/// (balance_in, balance_out) where balance_in in is how much has been
/// transferred into the flow, and balance_out is how much value transferred
/// out.
pub fn balance(&self) -> (Uint256, Uint256) {
pub fn _balance(&self) -> (Uint256, Uint256) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these renames?

@nicolaslara
Copy link

Can you write some docs explaining this mechanism?

From skimming the code it seems to be similar to transmutter pools where the change capacity is bounded by the moving average of past capacity. Is the advantage here making the limit changes smoother?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaslara nicolaslara nicolaslara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bonedaddy @nicolaslara