Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables utilities updates #154

Merged
merged 3 commits into from Sep 9, 2019
Merged

Variables utilities updates #154

merged 3 commits into from Sep 9, 2019

Conversation

billdingwall
Copy link

  1. Refactoring theme variables to separate the config from the compiled CSS, so the config can be imported directly in other apps.

example: https://github.com/teamsnap/organization-frontend/blob/master/src/styles/main.scss#L1

  1. Adding a few utilities for a few different projects going on right now

@billdingwall billdingwall mentioned this pull request Sep 5, 2019
Merged
bradcypert
bradcypert approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@bradcypert bradcypert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These change seem fine to me and shouldnt have any issues with the components side of things. I'm particularly excited about the Christmas Sweater theme. :)

saralohr
saralohr reviewed Sep 5, 2019
View reviewed changes
src/css/utils/border.scss Outdated

// Border Color

$border-radius: (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be $border-color?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks! updated

saralohr
saralohr approved these changes Sep 5, 2019
View reviewed changes
Copy link

@saralohr saralohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@billdingwall billdingwall merged commit 336c5fd into master Sep 9, 2019
@billdingwall billdingwall deleted the variables-utilities-updates branch September 9, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradcypert bradcypert bradcypert approved these changes

@saralohr saralohr saralohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@billdingwall @bradcypert @saralohr