Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and tweak scss compliation #665

Merged
merged 4 commits into from Jun 4, 2021
Merged

Upgrade and tweak scss compliation #665

merged 4 commits into from Jun 4, 2021

Conversation

l3aconator
Copy link
Contributor

@l3aconator l3aconator commented Jun 3, 2021

Context: When building the marketing site, our build tool fires off tons of deprecation notices per the following article: https://sass-lang.com/documentation/breaking-changes/slash-div

  • Remove node-sass for latest sass
  • Upgrade sass-loader to 10.2.0 <- this is the latest version we can go to given storybook
    • This was necessary to pick up the updated scss syntax
  • Run migration tool on the deprecated scss syntax
  • Upgrade gulp-sass

This PR needs a good amount of scrutiny and I will need help releasing to npm.

Copy link

@saralohr saralohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Happy to help with NPM deploy or we can get you added if you'd rather self-serve.

Copy link
Contributor

@bradjteamsnap bradjteamsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me as well, tried building the brach locally just to be sure 👍

@l3aconator
Copy link
Contributor Author

@saralohr I would love your help with the NPM deploy whenever you get a chance :)

@saralohr
Copy link

saralohr commented Jun 4, 2021

Sure @l3aconator I'll merge this and deploy to NPM.

@saralohr saralohr merged commit 632c4a3 into master Jun 4, 2021
@saralohr saralohr deleted the MAR-sass-fixes branch June 4, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants