Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for default parameters #33

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Fixes for default parameters #33

merged 3 commits into from
Feb 3, 2024

Conversation

ottojo
Copy link
Member

@ottojo ottojo commented Feb 2, 2024

  • Add start_type_description_service default parameter
  • Add toggle to show/hide default parameters

fixes #31

@ottojo ottojo requested a review from authaldo February 2, 2024 12:32
authaldo
authaldo reviewed Feb 2, 2024
View reviewed changes
src/service_wrapper.cpp Outdated Show resolved Hide resolved
@ottojo @authaldo
formatting
6e36742 
Co-authored-by: Dominik <45536968+authaldo@users.noreply.github.com>
@ottojo ottojo requested a review from authaldo February 3, 2024 08:07
authaldo
authaldo approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@authaldo authaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@authaldo authaldo merged commit 8c3e5b1 into master Feb 3, 2024
4 checks passed
@authaldo authaldo deleted the default_parameters branch February 3, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@authaldo authaldo authaldo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve default parameter hiding
2 participants
@ottojo @authaldo