Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd function overrides Laravel's implementation #36

Closed
acasar opened this issue Aug 29, 2016 · 1 comment
Closed

dd function overrides Laravel's implementation #36

acasar opened this issue Aug 29, 2016 · 1 comment

Comments

@acasar
Copy link
Contributor

acasar commented Aug 29, 2016

First, thanks a lot for creating this package! :)

I just noticed a small issue - Laravel already has a dd function defined, but there is also one defined in this package and it takes precedence over Laravel's implementation. I would like to continue using Laravel's dd, since it uses the Symfony var_dumper which results in a much more readable output.

Is there any chance that the dd function supplied with this package could be renamed since it's not really part of any core functionality?

@nticaric
Copy link
Contributor

nticaric commented Aug 29, 2016

I guess we can also remove the function, it's no longer needed. Would you mind creating a pull request?

acasar added a commit to acasar/tntsearch that referenced this issue Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants