Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more line breaks #45

Closed
mxcl opened this issue Jun 9, 2022 · 3 comments · Fixed by #49
Closed

Add more line breaks #45

mxcl opened this issue Jun 9, 2022 · 3 comments · Fixed by #49
Assignees

Comments

@mxcl
Copy link
Member

mxcl commented Jun 9, 2022

git/github use newline based diffs

This is making it hard to review pull-requests.

Merge all existing PRs then quickly insert newlines after period in the document.

@mxcl
Copy link
Member Author

mxcl commented Jun 9, 2022

Possibly at commas as well (provided the resulting segment is longer than a couple words that is).

@jhheider
Copy link
Member

jhheider commented Jun 9, 2022

Or just do it at 72 or 80 chars?

@mxcl
Copy link
Member Author

mxcl commented Jun 9, 2022

Good thinking but no because then people will feel compelled to re-linebreak if they make an edit that is longer than 72/80 characters leading to crappy diffs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants