Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split lines for easier PR review #49

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Split lines for easier PR review #49

merged 1 commit into from
Jun 9, 2022

Conversation

jhheider
Copy link
Member

@jhheider jhheider commented Jun 9, 2022

  • split every paragraph at sentence breaks (full-stop or question mark)
  • split lines longer than 360 characters at natural break points (clauses, primarily with commas)

recommend incorporating #30 once complete to prevent excess work.

resolves #45

@jhheider
split lines at sentence breaks
4b3af74 
Signed-off-by: Jacob Heider <jacob@tea.xyz>
@jhheider jhheider requested a review from mxcl June 9, 2022 18:19
@artburkart
Copy link
Contributor

This probably would've made #30 a little easier, eh? Too bad I didn't think of it. 😅

@artburkart
Copy link
Contributor

I'm already peeling #30 apart into smaller, merge-able pieces, so no worries from my end if this gets merged beforehand!

@jhheider
Copy link
Member Author

jhheider commented Jun 9, 2022

@artburkart , you are a scholar and a gentleman.

@jhheider jhheider removed the request for review from mxcl June 9, 2022 22:40
@jhheider jhheider merged commit 9fcddd8 into main Jun 9, 2022
@jhheider jhheider deleted the line-breaks branch June 9, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more line breaks
2 participants
@jhheider @artburkart