Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependency): phpunit 7.x #76

Merged
merged 1 commit into from
Sep 9, 2018
Merged

feat(dependency): phpunit 7.x #76

merged 1 commit into from
Sep 9, 2018

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Sep 9, 2018

upgrade package phpunit to branch 7.x

@natebrunette
Copy link
Member

Thanks 👍

@natebrunette
Copy link
Member

Needs composer update to ensure compatibility.

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Sep 9, 2018

You meed you need the lockfile ? I've updated and run unit tests locally.

@natebrunette
Copy link
Member

Yeah, we need a lockfile update, otherwise sensiolabs insights will complain.

@natebrunette
Copy link
Member

If you want to roll both PRs into one, that's ok with me.

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Sep 9, 2018

Yeah, we need a lockfile update, otherwise sensiolabs insights will complain.

Okay.

If you want to roll both PRs into one, that's ok with me.

Nah. Merge one first and I will rebase the second one ;)

Edit: php-parser first if possible ^^

upgrade package phpunit to branch 7.x

Signed-off-by: Levis Florian <levis.florian@gmail.com>
@natebrunette natebrunette merged commit ac2874d into tebru:master Sep 9, 2018
@Gounlaf Gounlaf deleted the dependencies/php-unit branch April 2, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants