New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks when used in browser with browserify #22
Comments
Which browser are you using? What version / OS? |
Actually it breaks before, as browserify does not succeed to pack all dependencies into a bundle. It fails because the named dependency is not used optionally and cannot work in the browser.
Gesendet mit TypeApp
Am 27. Juli 2017, 15:30, um 15:30, 404d356a256ae7b30f91cbc17c8d1c0b <notifications@github.com> schrieb:
…Which browser are you using? What version / OS?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#22 (comment)
|
Commit d2d762c should fix this, as I've added yargs to the browserify package ignore list. Could you check and see if version 2.5.4 works for you? The new changes are now in the master branch under /dist. |
Hi, thank you! I will check that on next thursday because I am out of office atm.
Gesendet mit TypeApp
Am 27. Juli 2017, 15:58, um 15:58, 404d356a256ae7b30f91cbc17c8d1c0b <notifications@github.com> schrieb:
…Commit
d2d762c
should fix this, as I've removed yargs to the browserify package ignore
list.
Could you check and see if version 2.5.4 fixes this?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#22 (comment)
|
Still breaks after d2d762c. |
Browser colors work now that To test locally using a containerized apache instance running on port 8070 as your webserver: git clone https://github.com/tecfu/tty-table
cd tty-table
docker run -dit --name my-apache-app -p 8070:80 -v "$PWD":/usr/local/apache2/htdocs/ httpd:2.4 In your browser navigate to http://localhost:8070/examples/browser-example.html |
When using in browser with browserify, recent builds break with the message:
The issue is, that there is no spawn-sync for browsers as spawning is not possible, I guess. So cross-spawn only works in node. I don't know if it was ever intended, but previous versions (until 2.2.x) worked great in the browsers console...
From Version 2.3.0 until the most recent versions, it does not work anymore.
For now I am sticking with version 2.2.5, as my module must work in node.js and browsers, using the table as debug output.
The text was updated successfully, but these errors were encountered: