New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: merge performance #33
Comments
Actually i made a PR : #34 |
Merged #34 |
tecfu
added a commit
that referenced
this issue
May 12, 2018
Thanks @vmarchaud |
Happy to give back ! Thanks for your module too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Summary
The
merge
module is slow, the cli that i'm building depend on it to render few lines, i'm seing a ~4x difference betweenObject.assign
andmerge
:Object.assign
:Merge
:Expected Result (screen shot if possible)
Actual Result (screen shot if possible)
Environment Information
OS: Uubuntu 17.10
Terminal Emulator:
Vscode (xterm.js)
Steps to Reproduce
Merge
here byObject.assign
Conclusion
Would it be possible to use
Object.assign
when available ? I dont mind making a PR if neededThe text was updated successfully, but these errors were encountered: