fix(fitHeight): improved algorithm simplified (#192)

tech-systems · Jul 9, 2023 · 42bccfa · 42bccfa
1 parent 3df5562
commit 42bccfa
Show file tree

Hide file tree

Showing 17 changed files with 11 additions and 189 deletions.
diff --git a/dist/core/index.js b/dist/core/index.js
diff --git a/dist/cupertino-pane.esm.js b/dist/cupertino-pane.esm.js
@@ -1,13 +1,13 @@
 /**
- * Cupertino Pane 1.3.32
+ * Cupertino Pane 1.3.33
  * New generation interfaces for web3 progressive applications
  * https://github.com/roman-rr/cupertino-pane/
  *
  * Copyright 2019-2023 Roman Antonov (roman-rr)
  *
  * Released under the MIT License
  *
- * Released on: July 9, 2023
+ * Released on: July 10, 2023
  */
 
 /******************************************************************************
@@ -1597,21 +1597,8 @@ class FitHeightModule {
             }
             yield Promise.all(promises);
             yield new Promise(resolve => requestAnimationFrame(resolve));
-            // Calculate heights
-            const getHeight = (el) => Math.round(el.getBoundingClientRect().height);
-            let contentElHeight = getHeight(this.instance.el);
-            let diff = this.contentElHeight - contentElHeight;
-            // If content el changes
-            let paneElHeight = getHeight(this.instance.paneEl);
-            if (Math.abs(diff)) {
-                paneElHeight -= diff;
-            }
-            // Set value for future checks
-            this.contentElHeight = getHeight(this.instance.el);
-            // Fit to screen if fitScreenHeight happens
-            if (getHeight(this.instance.el) > this.instance.screen_height) {
-                this.contentElHeight = this.instance.screen_height;
-            }
+            // Base calc
+            let paneElHeight = Math.round(this.instance.paneEl.getBoundingClientRect().height);
             // Hide elements back
             if (!this.instance.rendered) {
                 this.instance.el.style.visibility = 'unset';

diff --git a/dist/cupertino-pane.esm.min.js b/dist/cupertino-pane.esm.min.js
diff --git a/dist/cupertino-pane.esm.min.js.map b/dist/cupertino-pane.esm.min.js.map
diff --git a/dist/cupertino-pane.js b/dist/cupertino-pane.js
@@ -1,13 +1,13 @@
 /**
- * Cupertino Pane 1.3.32
+ * Cupertino Pane 1.3.33
  * New generation interfaces for web3 progressive applications
  * https://github.com/roman-rr/cupertino-pane/
  *
  * Copyright 2019-2023 Roman Antonov (roman-rr)
  *
  * Released under the MIT License
  *
- * Released on: July 9, 2023
+ * Released on: July 10, 2023
  */
 
 (function (global, factory) {
@@ -1603,21 +1603,8 @@
                 }
                 yield Promise.all(promises);
                 yield new Promise(resolve => requestAnimationFrame(resolve));
-                // Calculate heights
-                const getHeight = (el) => Math.round(el.getBoundingClientRect().height);
-                let contentElHeight = getHeight(this.instance.el);
-                let diff = this.contentElHeight - contentElHeight;
-                // If content el changes
-                let paneElHeight = getHeight(this.instance.paneEl);
-                if (Math.abs(diff)) {
-                    paneElHeight -= diff;
-                }
-                // Set value for future checks
-                this.contentElHeight = getHeight(this.instance.el);
-                // Fit to screen if fitScreenHeight happens
-                if (getHeight(this.instance.el) > this.instance.screen_height) {
-                    this.contentElHeight = this.instance.screen_height;
-                }
+                // Base calc
+                let paneElHeight = Math.round(this.instance.paneEl.getBoundingClientRect().height);
                 // Hide elements back
                 if (!this.instance.rendered) {
                     this.instance.el.style.visibility = 'unset';
@@ -2404,4 +2391,3 @@
     return CupertinoPane;
 
 }));
-//# sourceMappingURL=cupertino-pane.js.map
diff --git a/dist/cupertino-pane.js.map b/dist/cupertino-pane.js.map
diff --git a/dist/cupertino-pane.min.js b/dist/cupertino-pane.min.js
diff --git a/dist/cupertino-pane.min.js.map b/dist/cupertino-pane.min.js.map
diff --git a/dist/modules/backdrop.js b/dist/modules/backdrop.js
diff --git a/dist/modules/fit-height.js b/dist/modules/fit-height.js
diff --git a/dist/modules/follower.js b/dist/modules/follower.js
diff --git a/dist/modules/horizontal.js b/dist/modules/horizontal.js
diff --git a/dist/modules/index.js b/dist/modules/index.js