Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize window #76

Merged
merged 7 commits into from
Jun 4, 2023
Merged

Resize window #76

merged 7 commits into from
Jun 4, 2023

Conversation

hannesdelbeke
Copy link
Collaborator

@hannesdelbeke hannesdelbeke commented Jun 4, 2023

  • window now correctly remembers size, position, fullscreen, maximised state from previous session.
    this was currently prevented by the crash on exit. Not freed memory blocks on blender close #47
    • removed atexit module and on_exit method. since we could simplify the code
    • did not solve the crash on exit, for further debate on this see above linked issue
  • window now maintains the dimensions of the unwrapped blender window, if it was never wrapped before
    solving first time qt window size is too small #72
  • refactored some docstrings and constants

note

  • full screen or maximised state are not yet passed on first time wrap.
    seems overkill but we could always add it.

@hannesdelbeke hannesdelbeke linked an issue Jun 4, 2023 that may be closed by this pull request
@hannesdelbeke hannesdelbeke merged commit 0777cd6 into master Jun 4, 2023
@hannesdelbeke hannesdelbeke deleted the resize-window branch June 4, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

first time qt window size is too small
1 participant