Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching/redirect providers #3

Closed
cnuernber opened this issue Apr 21, 2020 · 3 comments
Closed

Remove caching/redirect providers #3

cnuernber opened this issue Apr 21, 2020 · 3 comments

Comments

@cnuernber
Copy link
Collaborator

Authentication makes sense -it would be a large burden to refactor existing code to explicitly pass in authentication information as opposed to what it is now

No one, absolutely no one aside from us is ever going to use the caching or redirect providers. They will just re-engineer some copy-local scheme and that will work fine for them.

Removing those two I think would simplify the library and focus it more as a launching point for url->data pathways where the url protocol dictates the underlying communication backend.

@cnuernber
Copy link
Collaborator Author

@harold, @charlesg3 - Need opinions here when you have time. I want to remove the parts of this library that we aren't using. The old s3 library always cached locally and I just at this point feel like that is better done as a layer on top as opposed to a layer inside.

@harold
Copy link
Contributor

harold commented Apr 21, 2020

Sounds good to me. Deleted code is debugged code.

@cnuernber
Copy link
Collaborator Author

Fixed in 8742ec7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants