Fixes #86

techascent · May 30, 2020 · 494104c · 494104c
1 parent f389625
commit 494104c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/tech/ml/dataset/join.clj b/src/tech/ml/dataset/join.clj
@@ -37,7 +37,7 @@
     (keyword? orign-name) (keyword new-name)
     (symbol? orign-name) (symbol new-name)
     :else
-    (keyword new-name)))
+    new-name))
 
 
 (defn- colname->lhs-rhs-colnames

diff --git a/test/tech/ml/dataset/join_test.clj b/test/tech/ml/dataset/join_test.clj
@@ -162,6 +162,18 @@
            (count (distinct (ds/column-names jt)))))))
 
 
+(deftest join-tuple-cname
+  (let [DS (ds/->dataset [{:a 11 [:a :b] 2}])
+        lj (ds/left-join :a DS DS)
+        rj (ds/right-join :a DS DS)
+        ljt (ds/left-join [[:a :b][:a :b]] DS DS)]
+    ;;no nil column names
+    (is (every? identity (ds/column-names lj)))
+    (is (every? identity (ds/column-names rj)))
+    (is (every? identity (ds/column-names ljt)))
+    ))
+
+
 
 (comment