Fixes #295

techascent · Mar 9, 2022 · 54143b4 · 54143b4
1 parent b0af4fa
commit 54143b4
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 7 deletions.
diff --git a/src/tech/v3/dataset.clj b/src/tech/v3/dataset.clj
@@ -4,6 +4,7 @@
   in memory datasets."
   (:require [tech.v3.dataset-api]
             [tech.v3.dataset.base]
+            [tech.v3.dataset.column]
             [tech.v3.dataset.impl.dataset]
             [tech.v3.dataset.io]
             [tech.v3.dataset.missing]
@@ -769,9 +770,16 @@ test/data/stocks.csv [10 3]:
 
 
 (defn new-column
-  "Create a new column from some values"
-  ([dataset column-name values]
-  (tech.v3.dataset.base/new-column dataset column-name values)))
+  "Create a new column.  Data will scanned for missing values
+  unless the full 4-argument pathway is used."
+  ([name data]
+  (tech.v3.dataset.column/new-column name data))
+  ([name data metadata]
+  (tech.v3.dataset.column/new-column name data metadata))
+  ([name data metadata missing]
+  (tech.v3.dataset.column/new-column name data metadata missing))
+  ([data-or-data-map]
+  (tech.v3.dataset.column/new-column data-or-data-map)))
 
 
 (defn new-dataset

diff --git a/src/tech/v3/dataset/metamorph.clj b/src/tech/v3/dataset/metamorph.clj
@@ -692,9 +692,16 @@ test/data/stocks.csv [10 3]:
 
 
 (defn new-column
-  "Create a new column from some values"
-  ([column-name values]
-  (tech.v3.dataset.metamorph-api/new-column column-name values)))
+  "Create a new column.  Data will scanned for missing values
+  unless the full 4-argument pathway is used."
+  ([data]
+  (tech.v3.dataset.metamorph-api/new-column data))
+  ([data metadata]
+  (tech.v3.dataset.metamorph-api/new-column data metadata))
+  ([data metadata missing]
+  (tech.v3.dataset.metamorph-api/new-column data metadata missing))
+  ([]
+  (tech.v3.dataset.metamorph-api/new-column )))
 
 
 (defn new-dataset

diff --git a/src/tech/v3/dataset_api.clj b/src/tech/v3/dataset_api.clj
@@ -54,7 +54,6 @@
                 has-column?
                 columns-with-missing-seq
                 add-column
-                new-column
                 remove-column
                 remove-columns
                 drop-columns
@@ -105,6 +104,9 @@
                 dataset?
                 empty-dataset)
 
+(export-symbols tech.v3.dataset.column
+                new-column)
+
 
 (defn rows
   "Get the rows of the dataset as a list of potentially flyweight maps.