Removed fastexcel as a required dependency as poi is more robust and …

…issue #283
techascent · Feb 4, 2022 · b1cb8d0 · b1cb8d0
1 parent f5fbeb6
commit b1cb8d0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
 # Changelog
+## 6.054-SNAPSHOT
+ * Removed fastexcel as an automatic dependency due to [ussue 283](https://github.com/techascent/tech.ml.dataset/issues/283).  The api documentation now 
+   indicates the known working fastexcel version.
+
 ## 6.053
  * Java API, Documentation and Sample.
  * Non-backward-compatible Fixes to rolling API's `:comp-fn` optional argument - the 

diff --git a/project.clj b/project.clj
@@ -11,7 +11,8 @@
                  [org.apache.poi/poi-ooxml         "5.1.0"
                   :exclusions [commons-codec]]
                  [org.dhatim/fastexcel-reader      "0.12.8"
-                  :exclusions [org.apache.poi/poi-ooxml]]
+                  :exclusions [org.apache.poi/poi-ooxml]
+                  :scope "provided"]
                  [com.github.haifengl/smile-core   "2.6.0"
                   :exclusions [org.slf4j/slf4j-api]]
                  [com.github.haifengl/smile-io     "2.6.0"

diff --git a/src/tech/v3/libs/fastexcel.clj b/src/tech/v3/libs/fastexcel.clj
@@ -9,7 +9,15 @@
 
   If you have an xlsx file that contains multiple sheets and you want a dataset
   out of each sheet you have to use `workbook->datasets` as opposed to the higher level
-  `->dataset` operator."
+  `->dataset` operator.
+
+  This dependency has a known conflict with cognitec's aws library - see [issue 283](https://github.com/techascent/tech.ml.dataset/issues/283).
+
+  Required Dependencies:
+
+```clojure
+  [org.dhatim/fastexcel-reader \"0.12.8\" :exclusions [org.apache.poi/poi-ooxml]]
+```"
   (:require [tech.v3.io :as io]
             [tech.v3.datatype.protocols :as dtype-proto]
             [tech.v3.datatype :as dtype]