fixing tests. Replace missing now takes a math equation.

techascent · Feb 14, 2019 · f0a0123 · f0a0123
1 parent 0ffa6af
commit f0a0123
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/tech/ml/dataset.clj b/src/tech/ml/dataset.clj
@@ -395,7 +395,7 @@ the correct type."
                                                 (first nonzero-entries) (keys inverse-map))
                                         {:entry-label (first nonzero-entries)
                                          :label-map label-map}))))))))
-      (let [column-values (-> (columns dataset src-column)
+      (let [column-values (-> (column dataset src-column)
                               ds-col/column-values)
             inverse-map (c-set/map-invert label-map)]
         (->> column-values

diff --git a/src/tech/ml/dataset/etl/math_ops.clj b/src/tech/ml/dataset/etl/math_ops.clj
@@ -123,6 +123,8 @@
     math-expr
     (number? math-expr)
     math-expr
+    (boolean? math-expr)
+    math-expr
     (sequential? math-expr)
     (let [fn-name (first math-expr)
           ;;Force errors early

diff --git a/src/tech/ml/dataset/etl/pipeline_operators.clj b/src/tech/ml/dataset/etl/pipeline_operators.clj
@@ -109,9 +109,9 @@
 (def-etl-operator
   replace-missing
 
-  {:missing-value (double (math-ops/eval-expr {:dataset dataset
-                                               :column-name column-name}
-                                              (first op-args)))}
+  {:missing-value (math-ops/eval-expr {:dataset dataset
+                                       :column-name column-name}
+                                      (first op-args))}
 
   (ds/update-column
    dataset column-name