Skip to content

Commit

Permalink
Fix issues reported by findbugs
Browse files Browse the repository at this point in the history
  • Loading branch information
saravanak committed Feb 2, 2014
1 parent 20ca60a commit 8ac8529
Show file tree
Hide file tree
Showing 9 changed files with 53 additions and 128 deletions.
7 changes: 5 additions & 2 deletions datastore/src/main/java/com/zols/datastore/domain/Entity.java
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,14 @@ public void setLabel(String label) {
}

public Date getCreatedDate() {
return createdDate;
if (createdDate != null)
return (Date)(createdDate.clone());
else
return null;
}

public void setCreatedDate(Date createdDate) {
this.createdDate = createdDate;
this.createdDate = (Date)(createdDate.clone());
}

}
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
package com.zols.templatemanager;

import com.zols.datastore.DataStore;
import com.zols.datastore.domain.NameLabel;
import com.zols.templatemanager.domain.TemplateRepository;
import java.io.File;
import java.io.FilenameFilter;
import java.io.IOException;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.List;

import org.apache.commons.net.ftp.FTPClient;
import org.apache.commons.net.ftp.FTPFile;
import org.apache.commons.net.ftp.FTPFileFilter;
Expand All @@ -18,6 +13,11 @@
import org.springframework.data.domain.Pageable;
import org.springframework.stereotype.Service;

import com.zols.datastore.DataStore;
import com.zols.datastore.domain.NameLabel;
import com.zols.templatemanager.domain.TemplateRepository;
import com.zols.utils.GenericExtFilter;

@Service
public class TemplateRepositoryManager {

Expand Down Expand Up @@ -124,23 +124,4 @@ private void populateTemplatesFromFileSystem(List<NameLabel> nameLabels, File di

}

// inner class, generic extension filter
private class GenericExtFilter implements FilenameFilter {

private String ext;

public GenericExtFilter(String ext) {
this.ext = ext;
}

public String getExt() {
return ext;
}

public boolean accept(File dir, String name) {
return ((!dir.getName().equals("mobile") && !dir.getName().equals("tablet")) && (name.endsWith(ext)
|| new File(dir.getAbsolutePath() + File.separator + name).isDirectory()));
}
}

}
23 changes: 23 additions & 0 deletions webmvc/src/main/java/com/zols/utils/GenericExtFilter.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package com.zols.utils;

import java.io.File;
import java.io.FilenameFilter;

public class GenericExtFilter implements FilenameFilter {

private String ext;

public GenericExtFilter(String ext) {
this.ext = ext;
}

public String getExt() {
return ext;
}

public boolean accept(File dir, String name) {
return ((!dir.getName().equals("mobile") && !dir.getName().equals(
"tablet")) && (name.endsWith(ext) || new File(
dir.getAbsolutePath() + File.separator + name).isDirectory()));
}
}
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
package org.zols.swagger;

import java.io.Serializable;

import org.springframework.stereotype.Component;

import com.mangofactory.swagger.EndpointComparator;
import com.wordnik.swagger.core.DocumentationEndPoint;
import org.springframework.stereotype.Component;

@Component
public class NameEndPointComparator implements EndpointComparator {
@Override
public class NameEndPointComparator implements EndpointComparator, Serializable {

private static final long serialVersionUID = 4617938503626112452L;

@Override
public int compare(DocumentationEndPoint first, DocumentationEndPoint second) {
return first.getPath().compareTo(second.getPath());
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
package org.zols.swagger;

import java.io.Serializable;

import org.springframework.stereotype.Component;

import com.mangofactory.swagger.OperationComparator;
import com.wordnik.swagger.core.DocumentationOperation;
import org.springframework.stereotype.Component;

@Component
public class NameOperationComparator implements OperationComparator {
@Override
public class NameOperationComparator implements OperationComparator, Serializable {

private static final long serialVersionUID = -8021586771596910344L;

@Override
public int compare(DocumentationOperation first, DocumentationOperation second) {
return first.getNickname().compareTo(second.getNickname());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import org.springframework.stereotype.Service;

@Service
public class ServiceMetaData implements com.zols.datastore.ServiceMetaData {
public class ServiceMetaDataImpl implements com.zols.datastore.ServiceMetaData {

@Autowired
private ServletContext servletContext;
Expand Down

This file was deleted.

This file was deleted.

41 changes: 0 additions & 41 deletions webmvc/src/test/resources/log4j.xml

This file was deleted.

0 comments on commit 8ac8529

Please sign in to comment.