Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed value tier prices converted to integer #6

Closed
ktruehl opened this issue May 15, 2019 · 1 comment
Closed

fixed value tier prices converted to integer #6

ktruehl opened this issue May 15, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ktruehl
Copy link

ktruehl commented May 15, 2019

Hello again!

I finally got around to upgrading to the latest release of the M2IF. Thanks so much for including the tier price import in the M2IF.

I did quite a bit of testing and it looks great so far. There are two issues, one is rather straight forward.

In src/Observers/PrepareTierPriceTrait.php on line 82 you convert the value to integer, even if the price type is "fixed".

Here our composer patch:
bugfix-[2.0]--do-not-convert-tier-price-to-integer.diff.zip

For the other problem I will create a separate issue.

Best,
Klaas

@wagnert wagnert self-assigned this May 15, 2019
@wagnert wagnert added the bug Something isn't working label May 15, 2019
@wagnert wagnert added this to In Progress in Pacemaker Community May 15, 2019
@wagnert
Copy link
Member

wagnert commented May 15, 2019

@ktruehl Thanks for the patch, will be released with the next version :-)

wagnert added a commit to wagnert/import-product-tier-price that referenced this issue May 16, 2019
@wagnert wagnert closed this as completed May 27, 2019
@wagnert wagnert moved this from In Progress to Testing in Pacemaker Community May 27, 2019
@wagnert wagnert moved this from Testing to Done in Pacemaker Community Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants