Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nullability #24

Closed
wants to merge 5 commits into from
Closed

Added nullability #24

wants to merge 5 commits into from

Conversation

degterev
Copy link

@degterev degterev commented Mar 5, 2018

There is the changes for better compatibility with swift.

I also updated cocoapods to 1.4.0 and Kiwi to 3.0.0

@fuzza
Copy link
Contributor

fuzza commented Mar 5, 2018

@degterev seems we need to update Fastlane to the most recent version and add try_repo_update_on_error parameter to cocoapods action in order to fix CI.

@fuzza
Copy link
Contributor

fuzza commented Mar 5, 2018

My general proposal for implementation is following
let's wrap all needed interfaces to NS_ASSUME_NONNUL_BEGINS / END macros and add only nullable annotations where it's needed. What do you think guys? @xNekOIx @degterev

fuzza
fuzza suggested changes Mar 5, 2018
View reviewed changes
Tests/FLXSerialExecutorSpec.m
[sut execute:nil];
}) should] raise];;
});
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we delete those tests? @degterev

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They didn't build, because method doesn't accept nil. Otherwise I can disable nullable errors for tests. @fuzza

@degterev
Copy link
Author

degterev commented Mar 5, 2018

@fuzza hey, I made all fixes that we had disucssed, can you check when you have a time?

@degterev degterev closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzza fuzza fuzza requested changes

@xNekOIx xNekOIx xNekOIx approved these changes

@MaxRandom MaxRandom MaxRandom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@degterev @fuzza @xNekOIx @MaxRandom