Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add a feature contribute goal #11

Merged
merged 6 commits into from
Mar 10, 2021
Merged

Conversation

jsryudev
Copy link
Contributor

@jsryudev jsryudev commented Mar 9, 2021

What does this PR do?

하루 커밋 목표 기능을 추가했습니다.

Why are we doing this?

저 같이 대결할 친구가 없는 경우 😭
스스로 목표를 설정하고 동기부여 할 수 있도록 목표 기능을 추가 했습니다.

Screenshots

image
image
image

Copy link
Owner

@techinpark techinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsryudev 너무 좋은 기능인거 같아요! 몇가지 내용 코멘트 드렸습니다. 기여해주셔서 감사합니다 👍

Sources/AppDelegate.swift Outdated Show resolved Hide resolved
Sources/AppDelegate.swift Outdated Show resolved Hide resolved
Sources/Models/ContributeData.swift Outdated Show resolved Hide resolved
Sources/Customs/IntegerValueFormatter.swift Show resolved Hide resolved
@jsryudev jsryudev requested a review from techinpark March 9, 2021 11:29
@techinpark
Copy link
Owner

@jsryudev 좋은 기능 기여 감사드립니다 v1.8 버전에 반영될 예정입니다 🎉 🎉

@techinpark techinpark merged commit fe2e3fd into techinpark:main Mar 10, 2021
@techinpark techinpark removed their request for review March 10, 2021 15:07
@jsryudev jsryudev deleted the feature/goal branch March 11, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants