Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/build-chown: limiting chown-ed files in build.sh #126

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

lruggieri
Copy link
Contributor

chown-ing the whole /build directory creates issues when running xgo in an environment with limited privileges (eg. most CIs).
As specified by the comment above the command, the purpose of this chown is to

set owner of created executables to owner of the /build directory

and since all executables start with $NAME, I think it's safe to limit which files are being chown-ed to the ones created by build.sh

@techknowlogick techknowlogick merged commit 6962a7c into techknowlogick:main Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants