Split out base and toolchain and ensure CI tests the current PR #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was another bug needing to be fixed in techknowlogick#187 - /source/go.mod does not exist in go-gettable modules therefore the NAME determination will fail. Fix techknowlogick#187 Signed-off-by: Andrew Thornton <art27@cantab.net>
Bootstrapping of arm-5, -6 and -7 currently happens in build.sh because Go will install std to /usr/local/go/pkg/linux_arm. This PR simply bootstraps these in bootstrap and moves them to /usr/local/go/pkg/linux_arm-x as appropriate with build.sh creating a symbolic link as needed. This should slightly speed up arm builds using xgo. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
This PR substantially restructures the xgo dockers creating a separate toolchain container, go-version container and then a merged container with the build.sh and xgo. This should in future allow for more caching and to be able to avoid rebuilding the whole toolchain. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
commented
Jan 14, 2023
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
split-out-toolchain
branch
from
afd47b7
to
5ac47e4
Compare
Signed-off-by: Andrew Thornton <art27@cantab.net>
…elevant to the toolchain Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Hopefully this might actually work in 0f2e6ff I've noticed another bug whilst working on this - I can extract out the fix if preferred. |
|
@techknowlogick would you be able to take a look at this? I've split base into a toolchain container containing the compilers. This toolchain is then used as the base for a bootstrapped go container which is finally then used to add xgo and the build.sh The test.yml has been extensively rewritten to ensure that the tests are run on the built container but it attempts to cache the toolchain docker if it's docker directory is unchanged. In doing this and running the tests I've noticed another bug and have also fixed that. |
Signed-off-by: Andrew Thornton <art27@cantab.net>
…ULE="auto" Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
This was referenced Jan 15, 2023
Merged
|
OK I'm convinced that this is now working and is a substantial improvement on the previous situation and fixes a number of issues therefore I'm gonna merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substantially restructures the xgo dockers creating a separate toolchain container, go-version container and then a merged container with the build.sh and xgo. This should in future allow for more caching and allows pr test cases to avoid rebuilding the whole toolchain.
In doing this I've noticed and fixed a number of bugs:
Fix #174
Fix #181
Fix #164
Fix #109
Signed-off-by: Andrew Thornton art27@cantab.net