Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring to keep main homesick class smaller. #107

Merged
merged 1 commit into from
Apr 16, 2014
Merged

Small refactoring to keep main homesick class smaller. #107

merged 1 commit into from
Apr 16, 2014

Conversation

JCook21
Copy link
Collaborator

@JCook21 JCook21 commented Apr 16, 2014

Small refactoring to move utility methods into their own module, keeping the main Homesick class smaller.

@nickmccurdy
Copy link
Collaborator

👍

I did something similar to this in my reorganize branch earlier, though I didn't get around to finishing it. Your change is simple enough that I think it's ready to get merged, and I might submit a pull request with some more minor refactoring after that (I wanted to move git helpers and stuff like that into separate files).

nickmccurdy added a commit that referenced this pull request Apr 16, 2014
@nickmccurdy
Merge pull request #107 from JCook21/Utils
41f3f9d 
Small refactoring to keep main homesick class smaller.
@nickmccurdy nickmccurdy merged commit 41f3f9d into technicalpickles:master Apr 16, 2014
@JCook21 JCook21 deleted the Utils branch April 16, 2014 19:18
@JCook21
Copy link
Collaborator Author

JCook21 commented Apr 17, 2014

@nicolasmccurdy thanks for merging this, looking forward to your refactoring PR too. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JCook21 @nickmccurdy