Refactor

[nickmccurdy]

• Homesick is now a module, not a class.
• The original Thor-related code in Homesick is now in the Homesick::CLI class.
• autoload calls have been removed, since it was an easy fix after ensuring that Homesick was a module (fixes Don't use autoload #108).
• Actions has now been split up into two modules: Actions::FileActions and Actions::GitActions.

[JCook21]

👍 Looks good and tests are still passing.

[nickmccurdy]

I also tried splitting up CLI into two modules, one for normal commands and one for git commands (especially since those might be deprecated or aliased eventually). However, I though it would probably be tricky with what's going on with Thor, and possibly confusing.

I'm thinking it might just be best to move the git commands to the bottom of the file together. What do you think?

[JCook21]

I'm not too worried about moving the Git commands, although feel free to do that if you like. I would like to get this merged though. Since there are quite a few changes in this I'd feel happier if someone else reviewed this first though. What do you think?

[nickmccurdy]

Since there are quite a few changes in this I'd feel happier if someone else reviewed this first though.

I agree. @technicalpickles would you mind checking this? My switch from autoload to require seems stable to me, but I just want to check that I haven't accidentally changed something unintentionally (since it's not loading those modules lazily any more).

[technicalpickles]

Looks good overall to me. Having a specific class for CLI is a pretty common pattern, and agree on Actions starting to get git. How do the tests look? Have you had much luck running this locally against your dotfiles? If you are happy with both those, should be good to merge & release.

[nickmccurdy]

Build 194 for b3bd7a1 is passing.

rake install works fine for me, and so do most other commands after some manual testing. I just noticed an issue with homesick symlink which is also in master, so I'll report that over at #112.

I would say that this is ready to merge, though we should probably wait to release until we figure out what's going on with this new bug.

[JCook21]

Alright, seeing as this is looking good I'm going to merge it.