Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional github integration (--[no-]github support) #186

Closed

Conversation

invadersmustdie
Copy link
Contributor

This patch allows the user to create a jeweler project structure without having any git(+hub) integration. I've added the option in a way the tool still behaves in the original way and tries to add fully github support, so it should provide full backward compatibility.

To disable github support the user just has to apply the --no-github option.

@technicalpickles
Copy link
Owner

Very nice. There's been a long standing request open for support for not using git/github, and this definitely is a step towards that.

I'll review & merge this soon (hopefully). One thing to consider would be how to document this in a way that folks can find it. If you can think of anything, by all means let me know!

@invadersmustdie
Copy link
Contributor Author

Readme file? Do you have release blog in jeweler?

Changing the current behavior to disable github support by default would be dramatic step but considerable for a further major release.

@technicalpickles
Copy link
Owner

Had a chance to look at this more closely, and it's actually reallllly close to being everything needed for non-git support. I've left some in line comments on the commits.

The only major consideration I can think of would be the impact of not having a git repository around when using the rake tasks. I'm not positive if they assume it's there or not, but it should be straightforward to only conditionally do some things.

@technicalpickles
Copy link
Owner

I'm closing out old PRs as part of #283 . I'm sorry I was never able to help get this to a point to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants