Revisit prometheus #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running this for awhile, but hadn't done anything meaningful. This should help prevent #59 again
I followed most of https://github.com/stefanprodan/dockprom . In summary:
I had to run node-exporter on the host, and left notes on the README. I did try running it under docker, but it was too much work to try to filter out the the false positives for filesystems, ie seemingly random mount points from files on the host to the container. You can see my work in the docker-compose.yml, figure i'd leave it.
I am using host networking in a lot of places, but I suspect it can be reduced a bit.