Brush component (old PR) #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying layerchart with
|
| Latest commit: |
f879a55
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34bc4ee4.layerchart.pages.dev |
| Branch Preview URL: | https://brush.layerchart.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f879a55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
…ng on range to clear. Move classes to Group contrainers
…e initializing selecction and reduce mapping (pixels <-> domain instead of pixels <-> percent <-> domain)
…variable per example, and use <LinearGradient> for Area fill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brush WIP
[ChartClipPath] Rename
includePaddingtofullto match<Frame>[Frame] Expose
rectEland forwardmousedownandtouchstartevents[Brush] Forward
mousedownandtouchstartevents[Brush] Use SVG/rect instaed of HTML/div
Forward
dblclickevent[Brush] Support double clicking on frame to select all, double clicking on range to clear. Move classes to Group contrainers
[Brush] Use domain values for min/max instead of percentages to enable initializing selecction and reduce mapping (pixels <-> domain instead of pixels <-> percent <-> domain)
Cleanup