Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated TransformContext #166

Merged
merged 15 commits into from
May 28, 2024
Merged

Integrated TransformContext #166

merged 15 commits into from
May 28, 2024

Conversation

techniq
Copy link
Owner

@techniq techniq commented May 25, 2024

Add new Canvas component (derived from LayerCake) which handles scaleCanvas() globally and supports scale/translate transforms

[GeoPath] Respect strokeWidth prop within Svg context (not just stroke-width attribute) to align with Canvas context usage

Integrate Transform into Chart () and expose as transformContext(). Renamed to TransformContext and removed direct SVG control (now handled by Svg and Canvas components)

…eCanvas()` globally and supports scale/translate transforms
…roke-width` attribute) to align with Canvas context usage
…orm>) and expose as `transformContext()`. Renamed to `TransformContext` and removed direct SVG control (now handled by `Svg` and `Canvas` components)
Copy link

cloudflare-pages bot commented May 25, 2024

Deploying layerchart with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bf6f7e
Status: ✅  Deploy successful!
Preview URL: https://101fe17b.layerchart.pages.dev
Branch Preview URL: https://canvas-improvements.layerchart.pages.dev

View logs

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
layerchart ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:14am

Copy link

changeset-bot bot commented May 25, 2024

🦋 Changeset detected

Latest commit: 3bf6f7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
layerchart Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner Author

techniq commented May 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @techniq and the rest of your teammates on Graphite Graphite

…ll want click events to send for small click/drags). Fixes regression using pointerevents. Add `dragging` store and translate deltaX/Y to context
… store in `GeoContext`, and wire up in `Chart` when GeoContext uses `applyTransform=['rotate']` to simplify interaction
…ne"` (default) with GeoContext's `applyTransform=[...]` and TransformConext's `processTransform()`
@techniq techniq marked this pull request as ready for review May 28, 2024 04:12
@techniq techniq merged commit 9f6c233 into main May 28, 2024
5 checks passed
@techniq techniq deleted the canvas-improvements branch May 28, 2024 11:18
@github-actions github-actions bot mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant