Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppLayout] Change nav overflow from scroll to auto #166

Closed
techniq opened this issue Jan 2, 2024 · 1 comment
Closed

[AppLayout] Change nav overflow from scroll to auto #166

techniq opened this issue Jan 2, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@techniq
Copy link
Owner

techniq commented Jan 2, 2024 •
edited
Loading

See discussion

Need to change overflow-scroll to overflow-auto so the scrollbars are only shown if the content overflows (more notable on Windows or Mac if you change your default scrollbar settings).

Semi related: #122 (but a bigger change, and will come after #66 is closed / #146 is merged).
@jycouet jycouet added the good first issue Good for newcomers label Jan 2, 2024
@techniq
Copy link
Owner Author

techniq commented Jan 2, 2024

You'll also want to create a changeset for this using pnpm changeset.

thedivtagguy added a commit to thedivtagguy/svelte-ux that referenced this issue Jan 3, 2024
@thedivtagguy
fix: change overflow to auto, resolves techniq#166
489bdd9
@techniq techniq closed this as completed in ea4f401 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@techniq @jycouet