Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing settingsClasses to Table.svelte #331

Closed
wants to merge 1 commit into from

Conversation

29th-Day
Copy link
Contributor

Table isnt stylable since the settingsClass isnt loaded. I noticed it in my own project, I dont know is its all changes needed.

Copy link

changeset-bot bot commented Apr 21, 2024

⚠️ No Changeset found

Latest commit: 9cd48ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-ux ❌ Failed (Inspect) Apr 21, 2024 7:07pm

@techniq
Copy link
Owner

techniq commented Apr 21, 2024

Thanks @29th-Day, but there is actually a commented out const settingsClasses = getComponentClasses('Table'); already in Table.svelte due to a circular reference I haven't been able to dig into and solve yet.

image

If you could find the solution I would love to enable this. Also, this PR has settingsClasses declared twice

image

@techniq
Copy link
Owner

techniq commented Apr 21, 2024

@29th-Day btw, I'm pretty sure the issue is using settingsClasses within the reactive variables headers and rowColumns. Not sure the best solution ATM, but it's solvable.

https://github.com/techniq/svelte-ux/blob/main/packages/svelte-ux/src/lib/components/Table.svelte#L52-L71

@techniq
Copy link
Owner

techniq commented Apr 21, 2024

also not sure why this creates a circular reference either.

@techniq
Copy link
Owner

techniq commented Apr 27, 2024

Tracking via #332 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants