Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #332

Merged
merged 15 commits into from
Jul 20, 2023
Merged

Fix CI #332

merged 15 commits into from
Jul 20, 2023

Conversation

sleiner
Copy link
Contributor

@sleiner sleiner commented Jul 16, 2023

Proposed Changes

  • Update pre-commit actions
    This was done by running pre-commit autoupdate --freeze.
  • Remove pre-commit only dependencies from requirements.in
    Including them in the file would create the illusion that those were the versions actually used in CI, but they are not.
    The exact versions are determined by the pre-commit hooks which are pinned in .pre-commit-config.yaml.

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 馃殌

This was done by running "pre-commit autoupdate --freeze".
Including them in the file would create the illusion that those were the
versions actually used in CI, but they are not. The exact versions are
determined by the pre-commit hooks which are pinned in
.pre-commit-config.yaml.
@timothystewart6
Copy link
Contributor

Thank you @sleiner super close, just looks like a few lint rules!

@sleiner
Copy link
Contributor Author

sleiner commented Jul 16, 2023

Yup - there are quite a few new ones now 馃槄 I'll fix these.

@sleiner sleiner changed the title Fix CI (hopefully) Fix CI Jul 16, 2023
@timothystewart6
Copy link
Contributor

timothystewart6 commented Jul 16, 2023

Thank you! I think we'll want to update our github actions to also use python 3.11 instead of 3.10, right?

https://github.com/techno-tim/k3s-ansible/blob/master/.github/workflows/test.yml#L17

https://github.com/techno-tim/k3s-ansible/blob/master/.github/workflows/lint.yml#L10

@timothystewart6
Copy link
Contributor

@sleiner what do you think?

@timothystewart6
Copy link
Contributor

I'll follow up to this in a PR

@timothystewart6
Copy link
Contributor

Thank you @sleiner !!

@timothystewart6 timothystewart6 merged commit 33ae0d4 into techno-tim:master Jul 20, 2023
5 checks passed
parkerg21 pushed a commit to ptg-homelab/k3s-ansible that referenced this pull request Sep 29, 2023
* Update pre-commit actions

This was done by running "pre-commit autoupdate --freeze".

* Remove pre-commit only dependencies from requirements.in

Including them in the file would create the illusion that those were the
versions actually used in CI, but they are not. The exact versions are
determined by the pre-commit hooks which are pinned in
.pre-commit-config.yaml.

* Ansible Lint: Fix role-name[path]

* Ansible Lint: Fix name[play]

* Ansible Lint: Fix key-order[task]

* Ansible Lint: Fix jinja[spacing]

* Ansible Lint: Fix no-free-form

* Ansible Lint: Fix var-naming[no-reserved]

* Ansible Lint: Fix yaml[comments]

* Ansible Lint: Fix yaml[line-length]

* Ansible Lint: Fix name[casing]

* Ansible Lint: Fix no-changed-when

* Ansible Lint: Fix fqcn[action]

* Ansible Lint: Fix args[module]

* Improve task naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants