Fix CI #332
Merged
Fix CI #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done by running "pre-commit autoupdate --freeze".
Including them in the file would create the illusion that those were the versions actually used in CI, but they are not. The exact versions are determined by the pre-commit hooks which are pinned in .pre-commit-config.yaml.
|
Thank you @sleiner super close, just looks like a few lint rules! |
|
Yup - there are quite a few new ones now 馃槄 I'll fix these. |
|
Thank you! I think we'll want to update our github actions to also use python 3.11 instead of 3.10, right? https://github.com/techno-tim/k3s-ansible/blob/master/.github/workflows/test.yml#L17 https://github.com/techno-tim/k3s-ansible/blob/master/.github/workflows/lint.yml#L10 |
|
@sleiner what do you think? |
|
I'll follow up to this in a PR |
|
Thank you @sleiner !! |
parkerg21
pushed a commit
to ptg-homelab/k3s-ansible
that referenced
this pull request
Sep 29, 2023
* Update pre-commit actions This was done by running "pre-commit autoupdate --freeze". * Remove pre-commit only dependencies from requirements.in Including them in the file would create the illusion that those were the versions actually used in CI, but they are not. The exact versions are determined by the pre-commit hooks which are pinned in .pre-commit-config.yaml. * Ansible Lint: Fix role-name[path] * Ansible Lint: Fix name[play] * Ansible Lint: Fix key-order[task] * Ansible Lint: Fix jinja[spacing] * Ansible Lint: Fix no-free-form * Ansible Lint: Fix var-naming[no-reserved] * Ansible Lint: Fix yaml[comments] * Ansible Lint: Fix yaml[line-length] * Ansible Lint: Fix name[casing] * Ansible Lint: Fix no-changed-when * Ansible Lint: Fix fqcn[action] * Ansible Lint: Fix args[module] * Improve task naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This was done by running
pre-commit autoupdate --freeze.Including them in the file would create the illusion that those were the versions actually used in CI, but they are not.
The exact versions are determined by the pre-commit hooks which are pinned in
.pre-commit-config.yaml.Checklist
site.ymlplaybookreset.ymlplaybook