Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded 'master' group name with 'group_name_master' variable #337

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

berendt
Copy link
Contributor

@berendt berendt commented Jul 20, 2023

Proposed Changes

For improved flexibility and maintainability.

  • Update tasks in node role to use 'group_name_master' variable instead of hardcoded 'master' group name
  • Update tasks in master role to use 'group_name_master' variable instead of hardcoded 'master' group name
  • Update tasks in post role to use 'group_name_master' variable instead of hardcoded 'master' group name

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 🚀

@timothystewart6
Copy link
Contributor

Thank you! While I do like this idea, I feel like this should be backwards compatible. Any way to make this default to master if this variable is not provided?

@timothystewart6
Copy link
Contributor

@berendt looks like yaml lint

@berendt
Copy link
Contributor Author

berendt commented Jul 21, 2023

Looks like pre-commit uses a different yamllint configuration then .yamllint? The line-length should be a warning only.

---
extends: default

rules:
  line-length:
    max: 120
    level: warning
  truthy:
    allowed-values: ['true', 'false', 'yes', 'no']

For improved flexibility and maintainability.

* Update tasks in node role to use 'group_name_master' variable instead
  of hardcoded 'master' group name
* Update tasks in master role to use 'group_name_master' variable instead
  of hardcoded 'master' group name
* Update tasks in post role to use 'group_name_master' variable instead of
  hardcoded 'master' group name

Signed-off-by: Christian Berendt <berendt@23technologies.cloud>
@timothystewart6
Copy link
Contributor

Good call, I will look into it. Might need to load the config...

@timothystewart6
Copy link
Contributor

Thank you!

@timothystewart6 timothystewart6 merged commit 215690b into techno-tim:master Jul 21, 2023
5 checks passed
parkerg21 pushed a commit to ptg-homelab/k3s-ansible that referenced this pull request Sep 29, 2023
…le (techno-tim#337)

For improved flexibility and maintainability.

* Update tasks in node role to use 'group_name_master' variable instead
  of hardcoded 'master' group name
* Update tasks in master role to use 'group_name_master' variable instead
  of hardcoded 'master' group name
* Update tasks in post role to use 'group_name_master' variable instead of
  hardcoded 'master' group name

Signed-off-by: Christian Berendt <berendt@23technologies.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants