Expand secure_path with support for Suse #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, not sure what happened with that test, "Failed to start the VM" seems like maybe the runner had some issues? |
|
No worries! Yeah, it happens from time to time. I just kicked it off again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Expanded the prereq role's secure_path task with support for Suse.
Added a default var (secure_path) for that task too, with separate values for RedHat and Suse.
(Didn't want to override Suse's default path order, nor RedHat's, I'm sure someone smarter than me decided on those orders for a reason)
Tested both site and reset.yml.
(Everything worked perfectly for openSUSE Leap 15.5 and SLES 15 SP5)
Checklist
site.ymlplaybookreset.ymlplaybook