Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(molecule): Cleanup all artifacts, side effects, and actions since nodes are not ephemeral #427

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(molecule): Cleanup all artifacts, side effects, and actions since nodes are not ephemeral #427

merged 1 commit into from
Jan 26, 2024

Conversation

timothystewart6
Copy link
Contributor

@timothystewart6 timothystewart6 commented Jan 26, 2024 •
edited
Loading

Cleanup all artifacts, side effects, and actions since nodes are not ephemeral

Proposed Changes

  • This is the cause of CI sometimes failing on self-hosted runners. Unfortunately the self hosted runners are not ephemeral nodes (and yet another reason GitHub actions should be containers!). Because they aren't and I don't have the sophistication that GitHub has with Azure, we need to clean up some of the side effects from our CI. This PR does that.

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 🚀

@timothystewart6 timothystewart6 enabled auto-merge (squash) January 26, 2024 17:05
@timothystewart6 timothystewart6 merged commit d910b83 into master Jan 26, 2024
6 checks passed
@timothystewart6 timothystewart6 deleted the cleanup-jobs branch January 26, 2024 17:16
timothystewart6 added a commit that referenced this pull request Jan 26, 2024
@timothystewart6
fix(molecule): Cleanup all artifacts, side effects, and actions in ca…
d8daf51 
…se nodes are not ephemeral (#427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timothystewart6