Matomo Support #111
Closed
Matomo Support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samip5
reviewed
Mar 16, 2022
| <script type="text/javascript"> | ||
| var _paq = window._paq || []; | ||
| /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ | ||
| _paq.push(['trackPageView']); |
There was a problem hiding this comment.
I think these should be configureable, as if I remember correctly, there's multiple one can add or not have and one shouldn't rely only on the JS code, unless client has to have js enabled too for the whole app to work.
There was a problem hiding this comment.
I didn't exactly know what this image tracking was and it didn't allow it in the head tag.
I just read how it works and it's basically what you are mentioning here.
I'm going to make a new pull request, already tested and it works on edge with javascript disabled (not allowed)
This reverts commit dc8b7aa.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Note: MATOMO_URL needs to be closed with a "/" like following example to work:
Checklist
yarn cito test my code